feat(helper): add Message class to handle message #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14132289657Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
A feature to add a new Message class for handling in-app messages in the client utilities.
- Introduces a Message class to create, display, and remove messages.
- Exports the new Message class via the utils index.
- Updates the ESLint configuration to allow empty private constructors.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/helper/src/client/utils/message.ts | Adds the Message class with pop, close, and destroy methods to manage messages. |
| tools/helper/src/client/utils/index.ts | Exports the newly added Message class. |
| eslint.config.js | Adds an ESLint rule to permit empty private constructors. |
Files not reviewed (1)
- tools/helper/src/client/styles/message.scss: Language not supported
Comments suppressed due to low confidence (1)
tools/helper/src/client/utils/message.ts:46
- [nitpick] Consider adding the option { once: true } to the 'animationend' event listener to ensure the listener is automatically removed after execution.
messageElement.addEventListener('animationend', () => {
|
|
||
| public pop(html: string, duration = 2000): number { | ||
| const messageElement = document.createElement('div') | ||
| const messageId = Date.now() |
There was a problem hiding this comment.
Using Date.now() to generate a messageId may lead to collisions if multiple messages are created in rapid succession. Consider using a more robust unique ID generator.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
@pengzhanbo I think the AI is right about this, any suggestions with it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.